beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1463) Update BigQuery read transform to handle 'null' values properly for DirectRunner
Date Fri, 10 Feb 2017 23:18:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861992#comment-15861992
] 

ASF GitHub Bot commented on BEAM-1463:
--------------------------------------

GitHub user chamikaramj opened a pull request:

    https://github.com/apache/beam/pull/1978

    [BEAM-1463] Updates BigQuery read transform to handle 'null' fields properly for DirectRunner

    Updates BigQuery read transform so that DirectRunner handles 'null' fields properly.
    
    Before this change, for DirectRunner, a record (dictionary) returned by BigQuery  read
transform did not contain keys for fields that are 'null'. For DataflowRunner, these fields
are available with value 'None'.
    I believe, retaining these fields value 'None' to be the proper behavior here.
    
    This change makes these two runners consistent when it comes to handling BigQuery 'null'
values.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/beam reading_null_fields_directrunner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1978
    
----
commit f6a94610b674760075c3c0af66b7b03da154f2bc
Author: Chamikara Jayalath <chamikara@google.com>
Date:   2017-02-10T22:19:53Z

    Updates BigQuery read transform so that DirectRunner handles 'null' fields properly.
    
    Before this change, for DirectRunner, a record (dictionary) returned by BigQuery  read
transform will not contain keys for fields that are 'null'. For DataflowRunner, these fields
will be available with value 'None'.
    I believe, retaining these fields value 'None' to be the proper behavior here.
    This change makes these two runners consistent when it comes to handling BigQuery 'null'
values.

----


> Update BigQuery read transform to handle 'null' values properly for DirectRunner
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-1463
>                 URL: https://issues.apache.org/jira/browse/BEAM-1463
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>
> Currently, for DirectRunner, a record (dictionary) returned by BigQuery  read transform
will not contain keys for fields that are 'null'. For DataflowRunner, these fields will be
available with value 'None'.
> I believe, retaining these fields with value 'None' to be the proper behavior here.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message