beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1430) PartitionFn should access only the element and not the context
Date Wed, 08 Feb 2017 07:06:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857537#comment-15857537
] 

ASF GitHub Bot commented on BEAM-1430:
--------------------------------------

GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/1947

    [BEAM-1430] PartitionFn should not access context and just the element

    PartitionFn currently has access to the complete process context. We should limit the
access to just the element to make it more NewDoFn like. This also removes the last uses on
ContextParam after #1942 
    
    R: @robertwb @aaltay PTAL
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1430-partition_fn_no_contexxt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1947.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1947
    
----
commit ca69524b54faede93df28d997e57da90c926f23c
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-02-08T00:16:49Z

    PartitionFn should not access context

----


> PartitionFn should access only the element and not the context
> --------------------------------------------------------------
>
>                 Key: BEAM-1430
>                 URL: https://issues.apache.org/jira/browse/BEAM-1430
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>    Affects Versions: Not applicable
>            Reporter: Sourabh Bajaj
>            Assignee: Sourabh Bajaj
>            Priority: Minor
>
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/core.py#L1182
should only access the element and not the full context.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message