beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Kirpichov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1417) Count should comply with PTransform style guide
Date Thu, 09 Feb 2017 00:54:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858796#comment-15858796
] 

Eugene Kirpichov commented on BEAM-1417:
----------------------------------------

PR https://github.com/apache/beam/pull/1943

> Count should comply with PTransform style guide
> -----------------------------------------------
>
>                 Key: BEAM-1417
>                 URL: https://issues.apache.org/jira/browse/BEAM-1417
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>
> Suggested change (backward-compatible): methods globally(), perKey(), perElement() should
return respective transform classes - Count.Globally, Count.PerKey, Count.PerElement. (currently
some of them return a PTransform which is actually a Combine - the suggestion is to wrap them
into classes).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message