beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Xu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (BEAM-1408) outputWithTimestamp() accepts timestamps that will fail preconditions
Date Mon, 06 Feb 2017 23:13:41 GMT
Andy Xu created BEAM-1408:
-----------------------------

             Summary: outputWithTimestamp() accepts timestamps that will fail preconditions
                 Key: BEAM-1408
                 URL: https://issues.apache.org/jira/browse/BEAM-1408
             Project: Beam
          Issue Type: Improvement
          Components: sdk-java-core
            Reporter: Andy Xu
            Assignee: Davor Bonaci
            Priority: Minor


We have accidentally created events with *wrong* timestamps in the future which are accepted
by
outputWithTimestamp(), but will fail at a later step:

java.lang.IllegalStateException: Timer 472976-06-15T20:09:57.269Z is beyond end-of-time
        atcom.google.cloud.dataflow.sdk.repackaged.com.google.common.base.Preconditions.checkState(Preconditions.java:199)
        at com.google.cloud.dataflow.sdk.util.ReduceFnRunner.scheduleEndOfWindowOrGarbageCollectionTimer(ReduceFnRunner.java:1050)
[...]

Would it make sense to implement a check already at outputWithTimestamp() level to fail early?




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message