beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davor Bonaci (JIRA)" <>
Subject [jira] [Commented] (BEAM-1404) Coveralls should not mark the build as "failed"
Date Mon, 06 Feb 2017 21:25:41 GMT


Davor Bonaci commented on BEAM-1404:

This is just a config number inside Coveralls, the default is zero. Easy to change once we
correct the underlying data.

> Coveralls should not mark the build as "failed"
> -----------------------------------------------
>                 Key: BEAM-1404
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Kenneth Knowles
>            Assignee: Jason Kuster
> For those folks who use the GitHub summary of the status of a PR, lots of good PRs are
marked failed because of Coveralls believing the coverage lowered by a few thousandths of
a percent. In fact, usually the decline is false / not possible, and even if it were, we should
be exercising human judgment about whether it was significant.
> So coveralls should not fail the build. Happy to leave every other bit in place as we
learn how to most effectively use it.

This message was sent by Atlassian JIRA

View raw message