beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Kirpichov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.
Date Tue, 07 Feb 2017 21:41:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856841#comment-15856841
] 

Eugene Kirpichov commented on BEAM-1402:
----------------------------------------

More specifically, the necessary changes are:

- Specify type parameters explicitly: TextIO.<Foo>read() etc.
- Get rid of classes like TextIO.Read.Bound - instead, TextIO.Read should be the transform
class itself
- Get rid of static builder-like .withBlah() methods - everything should be built using non-static
methods on top of .read(), .write() and alike
- Remove coders from the TextIO API
- (optional) use AutoValue

The PR already does the first 3 of these items.

> Make TextIO and AvroIO use best-practice types.
> -----------------------------------------------
>
>                 Key: BEAM-1402
>                 URL: https://issues.apache.org/jira/browse/BEAM-1402
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Reuven Lax
>            Assignee: Davor Bonaci
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message