beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1395) SparkGroupAlsoByWindowFn not sorting grouped elements by timestamp
Date Mon, 06 Feb 2017 04:44:41 GMT


ASF GitHub Bot commented on BEAM-1395:

GitHub user kennknowles opened a pull request:

    [BEAM-1395] Remove needless assumptions and complexity from GABWViaOutputBufferDoFn

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull GABWViaOutputBuffer

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1924
commit 781137fc2d2ce16c99e3294213755dd5645da832
Author: Kenneth Knowles <>
Date:   2017-02-06T04:42:03Z

    Remove extraneous chunking from GroupAlsoByWindowsViaOutputBufferDoFn

commit d8d74f689d91f5b9252fffec7d64b4f9fbd6bb56
Author: Kenneth Knowles <>
Date:   2017-02-06T04:42:51Z

    Remove incorrect pluralization from GroupAlsoByWindowsViaOutputBufferDoFn


> SparkGroupAlsoByWindowFn not sorting grouped elements by timestamp
> ------------------------------------------------------------------
>                 Key: BEAM-1395
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
> SparkGroupAlsoByWindowFn relies on the grouped elements (pre key) to be sorted by their
timestamp, which is not the case, and so could cause: 
> {code}
> IllegalStateException: Cannot move input watermark time backwards
> {code}
> We should sort the values first, just like with {{Combine}} implementations: 

This message was sent by Atlassian JIRA

View raw message