beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1388) Update default configuration of retry decorator so that wait times are more practical
Date Sat, 04 Feb 2017 01:38:52 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852463#comment-15852463
] 

ASF GitHub Bot commented on BEAM-1388:
--------------------------------------

GitHub user chamikaramj opened a pull request:

    https://github.com/apache/beam/pull/1916

    [BEAM-1388] Updates default values used by retry decorator.

    Updates following defaults so that total wait time by default is more practical.
    
    num_retries from 16 to 7.
    max_delay_secs from 4 hours to 1 hour.
    
    With this update, for maximum number of retries, system will wait for 635 sec while wait
before last retry being 320 sec.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/beam update_retry_defaults

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1916
    
----
commit 640f5c61a25c100df0eca79b1a4417b81dbb9a83
Author: Chamikara Jayalath <chamikara@google.com>
Date:   2017-02-04T01:32:49Z

    Updates default values used by retry decorator.

----


> Update default configuration of retry decorator so that wait times are more practical
> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-1388
>                 URL: https://issues.apache.org/jira/browse/BEAM-1388
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>
> Currently retry decorator [1] has following default configuration.
> initial delay: 5 sec
> number of retries: 16
> factor: 2
> max delay: 4 hours
> I propose updating these values to following so that default values are more practical.
> initial delay: 5 sec
> number of retries: 7
> factor: 2
> max delay: 1 hour
> With this update, for maximum number of retries, system will wait for 635 sec while wait
before last retry being 320 sec.
> [1] https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/retry.py#L117



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message