beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1382) Test that standard coders encode the same across SDKs
Date Fri, 03 Feb 2017 00:39:53 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850814#comment-15850814
] 

ASF GitHub Bot commented on BEAM-1382:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/1910

    [BEAM-1382] Unify encoding of common coders across SDKs

    Following Robert's original work in #1764,
    
    * move the `standard_coders.yaml` file to the `common/fn_api` module in a test resource
    * add the Java version of tests
    * make the Python TupleCoder (and hence KVCoder) be more efficient in outer context and
update spec so all 3 agree (spec, py, java).
    
    Known issues:
    - [ ] the python standard_coder_test ought to be failing to find the file, but `mvn clean
install` locally does not fail. Still investigating.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam coder-crosssdk-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1910
    
----
commit 9b9af32927cef3fc40047f62dd27f1a8165b5cbc
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-02-02T01:28:44Z

    Implement tests that coders are equivalent across-sdks
    
    Building off of the existing tests for Python SDK and unifying semantics.

commit 1cd5d58412a0c38967886920c244ad0fec766005
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-02-02T23:27:54Z

    fixup! lint fixes

----


> Test that standard coders encode the same across SDKs
> -----------------------------------------------------
>
>                 Key: BEAM-1382
>                 URL: https://issues.apache.org/jira/browse/BEAM-1382
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model-fn-api, beam-model-runner-api
>    Affects Versions: Not applicable
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: Not applicable
>
>
> There are a set of coders that cross the Fn Harness -- SDK Harness boundary. These coders
need to be consistent across SDKs (and the Fn harness as well). We should have a standard,
language-independent test spec and then actually exercise it in both current SDKs (and all
future ones).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message