beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1346) Drop Late Data in ReduceFnRunner
Date Mon, 13 Feb 2017 21:16:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864437#comment-15864437
] 

Kenneth Knowles commented on BEAM-1346:
---------------------------------------

I agree with your paranoia. This is related to BEAM-696. I think {{PushbackSideInputRunner}}
is technically OK because it pushes all the complexity to the runner. The runner can provide
a {{ReadyCheckingSideInputReader}} that understands the merging, and the runner decides when
to wake up the processing and feed the pushed-back elements, so it can alter its timers, etc,
according to merging. And if this is all too complex, maybe the runner can [disable any troublesome
optimizations|https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java#L811]
for now.

> Drop Late Data in ReduceFnRunner
> --------------------------------
>
>                 Key: BEAM-1346
>                 URL: https://issues.apache.org/jira/browse/BEAM-1346
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>    Affects Versions: 0.5.0
>            Reporter: Aljoscha Krettek
>
> I think these two commits recently broke late-data dropping for the Flink Runner (and
maybe for other runners as well):
> - https://github.com/apache/beam/commit/2b26ec8
> - https://github.com/apache/beam/commit/8989473
> It boils down to the {{LateDataDroppingDoFnRunner}} not being used anymore  because {{DoFnRunners.lateDataDroppingRunner()}}
is not called anymore when a {{DoFn}} is a {{ReduceFnExecutor}} (because that interface was
removed).
> Maybe we should think about dropping late data in another place, my suggestion is {{ReduceFnRunner}}
but that's open for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message