beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1334) Split UsesMetrics category and tests into UsesCommittedMetrics and UsesAttemptedMetrics
Date Thu, 02 Feb 2017 01:20:51 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849227#comment-15849227
] 

ASF GitHub Bot commented on BEAM-1334:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1865


> Split UsesMetrics category and tests into UsesCommittedMetrics and UsesAttemptedMetrics
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-1334
>                 URL: https://issues.apache.org/jira/browse/BEAM-1334
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>            Priority: Minor
>
> Some runners may not be able to implement both {{committed}} and {{attempted}} results
in {{MetricResult}}.
> Seeing this, split the current {{RunnableOnService}} test {{org.apache.beam.sdk.metrics.MetricsTest#metricsReportToQuery}}
into two tests, which test attempted and committed results separately with categories {{UsesCommittedMetrics}}
and {{UsesAttemptedMetrics}} instead of the current category {{UsesMetrics}}.
> Discussion that led to this can be seen in the this [PR|https://github.com/apache/beam/pull/1750#issuecomment-275412984]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message