beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1310) Add running integration tests for JdbcIO
Date Thu, 23 Feb 2017 22:39:44 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881455#comment-15881455
] 

ASF GitHub Bot commented on BEAM-1310:
--------------------------------------

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2090

    [BEAM-1310] Jdbc IO module now can run ITs against spark & dataflow runners

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    I have added some changes that will allow us to start running the JdbcIO ITs with spark
& dataflow.
    
    These 2 commits are deliberately separate since they're doing different things. I don't
think it's worth separating out into different commits since both are moving towards the same
goal of enabling JdbcIOIT to actually run in jenkins, and can be logically reviewed together.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam jdbc-it-profiles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2090
    
----

----


> Add running integration tests for JdbcIO
> ----------------------------------------
>
>                 Key: BEAM-1310
>                 URL: https://issues.apache.org/jira/browse/BEAM-1310
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>
> Jdbc IO could use some integration tests! We'd like to have them run against a real list
instance of postgres.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message