beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1304) NPE if trying to get value of Aggregator that does not exist.
Date Sun, 05 Feb 2017 14:03:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853232#comment-15853232
] 

ASF GitHub Bot commented on BEAM-1304:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1921


> NPE if trying to get value of Aggregator that does not exist.
> -------------------------------------------------------------
>
>                 Key: BEAM-1304
>                 URL: https://issues.apache.org/jira/browse/BEAM-1304
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Stas Levin
>
> Querying a specific aggregator value in {{SparkPipelineResult}} could throw NPE if the
get Aggregator name doesn't exist.
> This is the root of the problem: https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/aggregators/NamedAggregators.java#L74
> {{Map#get()}} will return {{null}}.  
> We could either return {{null}}, though this could simply propagate the problem upstream,
or use {{Optional}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message