beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stas Levin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1223) Replace public constructors with static factory methods for Sum.[*]Fn classes
Date Mon, 06 Feb 2017 08:06:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853651#comment-15853651
] 

Stas Levin commented on BEAM-1223:
----------------------------------

Hi [~dhalperi@google.com],

Sure thing, I was not aware of this label.
I'll make sure to use it to tag future backward incompatible changes.


> Replace public constructors with static factory methods for Sum.[*]Fn classes
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-1223
>                 URL: https://issues.apache.org/jira/browse/BEAM-1223
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
>              Labels: backward-incompatible
>             Fix For: 0.5.0
>
>
> {{Sum.SumDoubleFn}}, {{SumIntegerFn}} and {{SumLongFn}} are not using the {{X.of()}}
or {{X.from()}} or other instance creation via static method patterns that are ubiquitous
in Beam.
> Following a discussion on the dev list, it would be great to preserve a consistent look
and feel and change the creation patterns for these classes to something like {{SumFn.ofLong()}}
etc.
> See also the corresponding [dev list thread|https://lists.apache.org/thread.html/5d8e905ee49b116d13811c2a96da65eeb44ab7c002870f50936ee1ad@%3Cdev.beam.apache.org%3E].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message