beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1195) Give triggers a cross-language serialization schema
Date Mon, 13 Feb 2017 04:20:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863190#comment-15863190
] 

ASF GitHub Bot commented on BEAM-1195:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/1988

    [BEAM-1195, BEAM-115] Add full-fidelity conversion to/from Java SDK triggers and Runner
API protos

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This PR has somewhat independent commits that make sense to review together:
    
    1. Alter the Java SDK's trigger classes to have the necessary functionality to reconstruct
easily from a serialized form.
    2. Simplify some inheritances relationship in the Java SDK that were actually incorrect.
    3. Flesh out the Runner API proto to include all the needed bits to serialize triggers
fully.
    4. Actually serialize triggers and their inverse; test the round trip.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam trigger-proto

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1988
    
----
commit 46df18fc2a0de22ced7dbeaf47508a5bdd9c1493
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T23:03:48Z

    Reify delay and alignment in AfterProcessingTime transform

commit 8d62655b75377be8d0a6be2803abf25882d36663
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T00:47:15Z

    Add runner API config to poms

commit 16d5704ec5f6a0db8c678c69f2acc122aa1e0b4a
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T00:48:05Z

    Fix typo in runner API generated Java class

commit 412145654af5f126776913fcc99595a729f10967
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T01:26:56Z

    Add neglected ElementCount trigger to runner API proto

commit 0b222ed0aa653faf1d3cd39873f2ff845016f2f8
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T01:32:21Z

    Add TimeDomain to runner API protos

commit 1e669eecaadadb1e8cbf5b031aff613efe30c0db
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T01:38:01Z

    Flesh out AfterProcessingTime in runner API

commit 6954b4c539568b463aa602e012fa5aad2309a741
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T23:53:17Z

    Upgrade Java triggers to support runner API deserialization

commit 3100790d33dfa741c24fd62002cc62b17b142342
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-12T01:50:27Z

    Add conversion to/from Java SDK trigger to runner API proto

commit 69d0957d1109125294be5f057643684ea005dd06
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-13T04:11:59Z

    fixup! Reify delay and alignment in AfterProcessingTime transform

----


> Give triggers a cross-language serialization schema
> ---------------------------------------------------
>
>                 Key: BEAM-1195
>                 URL: https://issues.apache.org/jira/browse/BEAM-1195
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-runner-api
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> We have recently gotten to the point where triggers are just syntax, but it is still
shipped via Java serialization. To make it language-independent, we need a concrete syntax.
> Something like the following is fairly concise, tag adjacent to payload. I haven't bothered
making up fully verbose/namespaced URNs here.
> {code}
> {
>     "$urn": "OrFinally",
>     "main": {
>       "$urn": "EndOfWindow",
>       "early": <foo>
>     },
>     "finally": {
>       "$urn": "AfterCount",
>       "count": 45
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message