beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-882) Make ApiSurfaceTest detect the java package/module under test
Date Wed, 01 Feb 2017 15:40:51 GMT


ASF GitHub Bot commented on BEAM-882:

GitHub user staslev opened a pull request:

    [BEAM-882,BEAM-883,BEAM-878] Simplified API surface verifications (take 2)

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull Another-go-at-BEAM-882-BEAM-883-BEAM-878-Simplified-API-surface-verifications

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1888


> Make ApiSurfaceTest detect the java package/module under test
> -------------------------------------------------------------
>                 Key: BEAM-882
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: Not applicable
>            Reporter: Kenneth Knowles
>            Assignee: Stas Levin
>            Priority: Trivial
>              Labels: easy, easyfix, newbie, starter
>             Fix For: Not applicable
> {{ApiSurfaceTest}} in the {{sdks/java/core}} is the class responsible for protecting
our public API surface.
> This test walks the public signatures of all modules and explicitly verifies that everything
is on a whitelist. This is how we control what dependencies we expose to our users, so that
Beam can keep a tight, stable API surface.
> Today you must indicate what Java package to scan, such as `org.apache.beam.sdk`. It
would be nice for this to be automatically determined.

This message was sent by Atlassian JIRA

View raw message