beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-646) Get runners out of the apply()
Date Fri, 17 Feb 2017 23:03:44 GMT


ASF GitHub Bot commented on BEAM-646:

GitHub user tgroh opened a pull request:

    [BEAM-646] Use Surgery in the Dataflow Runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Couple of cleanups and underlying PRs still have to be submitted prior to actual review.
    I do want to use this PR to run some RunnableOnService Tests, though.

You can merge this pull request into a Git repository by running:

    $ git pull dataflow_runner_surgery

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2039
commit 02f01effdcf1a9a01dd1f0c6c94a3d025d16c064
Author: Thomas Groh <>
Date:   2017-02-16T22:44:16Z

    Move Batch View Overrides out of DataflowRunner
    Although these are runner specific, they don't need to be in the runner
    shim class.

commit e344eaf70500c5594818b36df3047147ae0486d1
Author: Thomas Groh <>
Date:   2017-02-16T22:58:52Z

    Move Streaming View Overrides out of the DataflowRunner
    These overrides are implementation details of the runner and
    runner-specific, but need not be within the Runner shim.

commit 71257024a18ccee8b881ae15be12145efefccd15
Author: Thomas Groh <>
Date:   2017-02-17T03:14:23Z

    Add a Base OverrideFactory class for 1-to-1 overrides
    These overrides are relatively common, and this reduces the
    reimplementation of mapping singletons and casting them.

commit 46d6b1e12c9138516cd111b853bfb06fe545deab
Author: Thomas Groh <>
Date:   2017-02-16T21:57:21Z

    Make Dataflow perform Surgery
    It's not Rocket Surgery, guys.


> Get runners out of the apply()
> ------------------------------
>                 Key: BEAM-646
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>              Labels: backwards-incompatible
> Right now, the runner intercepts calls to apply() and replaces transforms as we go. This
means that there is no "original" user graph. For portability and misc architectural benefits,
we would like to build the original graph first, and have the runner override later.
> Some runners already work in this manner, but we could integrate it more smoothly, with
more validation, via some handy APIs on e.g. the Pipeline object.

This message was sent by Atlassian JIRA

View raw message