beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-463) BoundedHeapCoder should be a StandardCoder and not a CustomCoder
Date Sat, 25 Feb 2017 04:37:44 GMT

    [ https://issues.apache.org/jira/browse/BEAM-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884020#comment-15884020
] 

ASF GitHub Bot commented on BEAM-463:
-------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/2108

    [BEAM-463] [BEAM-464] [BEAM-466] BoundedHeapCoder, HolderCoder, QuantileStateCoder ->
StandardCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam standard-coders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2108
    
----
commit 31cbd17dc51ea4101e4a22f9a9908a24bd529056
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2017-02-25T04:32:45Z

    [BEAM-463] BoundedHeapCoder should be a StandardCoder and not a CustomCoder

commit 9e94a7ffa3a82e2b780e2f06295a8640bb6de8d1
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2017-02-25T04:33:09Z

    [BEAM-464] HolderCoder should be a StandardCoder and not a CustomCoder

commit 57162682aae60ebf1f2928ffa37d76a5623294b7
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2017-02-25T04:33:33Z

    [BEAM-466] QuantileStateCoder should be a StandardCoder

----


> BoundedHeapCoder should be a StandardCoder and not a CustomCoder
> ----------------------------------------------------------------
>
>                 Key: BEAM-463
>                 URL: https://issues.apache.org/jira/browse/BEAM-463
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Assignee: Davor Bonaci
>            Priority: Minor
>              Labels: backward-incompatible
>
> The issue is that BoundedHeapCoder does not report component encodings which prevents
effective runner inspection of the components.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message