beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neelesh Srinivas Salian (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (BEAM-421) StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state
Date Mon, 27 Feb 2017 17:32:45 GMT

     [ https://issues.apache.org/jira/browse/BEAM-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Neelesh Srinivas Salian reassigned BEAM-421:
--------------------------------------------

    Assignee: Neelesh Srinivas Salian  (was: Neelesh Srinivas Salian)

> StateTags$CombiningValueStateTag inherits equals from super class but without incorporating
its state
> -----------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-421
>                 URL: https://issues.apache.org/jira/browse/BEAM-421
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Neelesh Srinivas Salian
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs EQ_DOESNT_OVERRIDE_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L555]:
Class doesn't override equals in superclass
> Applies to: [StateTags$CombiningValueStateTag|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java#L344].
CombiningValueStateTag inherits its equals implementation from its parent class, KeyedCombiningValueStateTag.
CombiningValueStateTag has additional fields which are not included in the equality implementation,
which may be incorrect.
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message