beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalp...@apache.org
Subject [1/2] beam git commit: [BEAM-1453] LocalResourceIdTest: disable unicode tests.
Date Fri, 10 Feb 2017 06:20:31 GMT
Repository: beam
Updated Branches:
  refs/heads/master c88297680 -> 712a1d6e3


[BEAM-1453] LocalResourceIdTest: disable unicode tests.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/7829dc86
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/7829dc86
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/7829dc86

Branch: refs/heads/master
Commit: 7829dc8638b4409cfd729854ccb484e7da6b0a53
Parents: c882976
Author: Pei He <peihe@google.com>
Authored: Thu Feb 9 15:52:33 2017 -0800
Committer: Dan Halperin <dhalperi@google.com>
Committed: Thu Feb 9 22:03:31 2017 -0800

----------------------------------------------------------------------
 .../apache/beam/sdk/io/LocalResourceIdTest.java | 24 ++------------------
 1 file changed, 2 insertions(+), 22 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/7829dc86/sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalResourceIdTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalResourceIdTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalResourceIdTest.java
index 94e7620..37bd303 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalResourceIdTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalResourceIdTest.java
@@ -32,6 +32,8 @@ import org.junit.runners.JUnit4;
 
 /**
  * Tests for {@link LocalResourceId}.
+ *
+ * <p>TODO: re-enable unicode tests when BEAM-1453 is resolved.
  */
 @RunWith(JUnit4.class)
 public class LocalResourceIdTest {
@@ -68,16 +70,6 @@ public class LocalResourceIdTest {
         toResourceIdentifier("file:/aa"),
         toResourceIdentifier("file:///")
             .resolve("aa", StandardResolveOptions.RESOLVE_FILE));
-
-    // Tests path with unicode
-    assertEquals(
-        toResourceIdentifier("/根目录/输出 文件01.txt"),
-        toResourceIdentifier("/根目录/")
-            .resolve("输出 文件01.txt", StandardResolveOptions.RESOLVE_FILE));
-    assertEquals(
-        toResourceIdentifier("file://根目录/输出 文件01.txt"),
-        toResourceIdentifier("file://根目录/")
-            .resolve("输出 文件01.txt", StandardResolveOptions.RESOLVE_FILE));
   }
 
   @Test
@@ -199,15 +191,6 @@ public class LocalResourceIdTest {
         toResourceIdentifier("/"),
         toResourceIdentifier("/").getCurrentDirectory());
 
-    // Tests path with unicode
-    assertEquals(
-        toResourceIdentifier("/根目录/"),
-        toResourceIdentifier("/根目录/输出 文件01.txt").getCurrentDirectory());
-    assertEquals(
-        toResourceIdentifier("file://根目录/"),
-        toResourceIdentifier("file://根目录/输出 文件01.txt").getCurrentDirectory());
-
-
     // Tests path without parent.
     assertEquals(
         toResourceIdentifier("./"),
@@ -218,9 +201,6 @@ public class LocalResourceIdTest {
   public void testGetScheme() throws Exception {
     // Tests for local files without the scheme.
     assertEquals("file", toResourceIdentifier("/root/tmp/").getScheme());
-
-    // Tests path with unicode.
-    assertEquals("file", toResourceIdentifier("file://根目录/").getScheme());
   }
 
   @Test


Mime
View raw message