beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stasle...@apache.org
Subject [1/2] beam git commit: Fixed javadoc comment in ResumeFromCheckpointStreamingTest.
Date Mon, 13 Feb 2017 10:47:02 GMT
Repository: beam
Updated Branches:
  refs/heads/master 93ae666be -> 4beed50f2


Fixed javadoc comment in ResumeFromCheckpointStreamingTest.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/2f63b1f6
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/2f63b1f6
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/2f63b1f6

Branch: refs/heads/master
Commit: 2f63b1f63fefaff996c4ae267af8a01a5718e0c0
Parents: 93ae666
Author: Aviem Zur <aviemzur@gmail.com>
Authored: Sun Feb 12 19:56:48 2017 +0200
Committer: Stas Levin <staslevin@apache.org>
Committed: Mon Feb 13 12:40:23 2017 +0200

----------------------------------------------------------------------
 .../streaming/ResumeFromCheckpointStreamingTest.java     | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/2f63b1f6/runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java
----------------------------------------------------------------------
diff --git a/runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java
b/runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java
index 7094c86..5a27b29 100644
--- a/runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java
+++ b/runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java
@@ -64,12 +64,7 @@ import org.junit.rules.TemporaryFolder;
 
 
 /**
- * Tests DStream recovery from checkpoint - recreate the job and continue (from checkpoint).
- *
- * <p>Tests Aggregators, which rely on Accumulators - Aggregators should be available,
though
- * state is not preserved (Spark issue), so they start from initial value.
- * //TODO: after the runner supports recovering the state of Aggregators, update this test's
- * expected values for the recovered (second) run.
+ * Test pipelines which are resumed from checkpoint.
  */
 public class ResumeFromCheckpointStreamingTest {
   private static final EmbeddedKafkaCluster.EmbeddedZookeeper EMBEDDED_ZOOKEEPER =
@@ -118,6 +113,10 @@ public class ResumeFromCheckpointStreamingTest {
         }
   }
 
+  /**
+   * Tests DStream recovery from checkpoint - recreate the job and continue (from checkpoint).
+   * <p>Also tests Aggregator values, which should be restored upon recovery from checkpoint.</p>
+   */
   @Test
   public void testRun() throws Exception {
     Duration batchIntervalDuration = Duration.standardSeconds(5);


Mime
View raw message