Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D8C8200C18 for ; Sat, 7 Jan 2017 02:41:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5C307160B48; Sat, 7 Jan 2017 01:41:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AFEFE160B4C for ; Sat, 7 Jan 2017 02:41:02 +0100 (CET) Received: (qmail 89623 invoked by uid 500); 7 Jan 2017 01:41:01 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 89588 invoked by uid 99); 7 Jan 2017 01:41:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jan 2017 01:41:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A8FF6DF9FD; Sat, 7 Jan 2017 01:41:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: robertwb@apache.org To: commits@beam.apache.org Date: Sat, 07 Jan 2017 01:41:01 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] beam git commit: Remove the pipeline_type_check option archived-at: Sat, 07 Jan 2017 01:41:03 -0000 Repository: beam Updated Branches: refs/heads/python-sdk 296fdcdb3 -> 69d8f2bf1 Remove the pipeline_type_check option Default value is True for this option and --pipeline_type_check is a noop. (Still keeping the --no_pipeline_type_check for optionally disabling this check.) Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/75ce5544 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/75ce5544 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/75ce5544 Branch: refs/heads/python-sdk Commit: 75ce5544ba18a14df3171167f6aaa9b361b262fd Parents: 296fdcd Author: Ahmet Altay Authored: Fri Jan 6 11:19:55 2017 -0800 Committer: Ahmet Altay Committed: Fri Jan 6 11:19:55 2017 -0800 ---------------------------------------------------------------------- .../apache_beam/examples/cookbook/group_with_coder_test.py | 5 ++--- sdks/python/apache_beam/utils/pipeline_options.py | 4 ---- 2 files changed, 2 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/75ce5544/sdks/python/apache_beam/examples/cookbook/group_with_coder_test.py ---------------------------------------------------------------------- diff --git a/sdks/python/apache_beam/examples/cookbook/group_with_coder_test.py b/sdks/python/apache_beam/examples/cookbook/group_with_coder_test.py index fb52809..268ba8d 100644 --- a/sdks/python/apache_beam/examples/cookbook/group_with_coder_test.py +++ b/sdks/python/apache_beam/examples/cookbook/group_with_coder_test.py @@ -43,13 +43,12 @@ class GroupWithCoderTest(unittest.TestCase): return f.name def test_basics_with_type_check(self): - # Run the workflow with --pipeline_type_check option. This will make sure + # Run the workflow with pipeline_type_check option. This will make sure # the typehints associated with all transforms will have non-default values # and therefore any custom coders will be used. In our case we want to make # sure the coder for the Player class will be used. temp_path = self.create_temp_file(self.SAMPLE_RECORDS) group_with_coder.run([ - '--pipeline_type_check', '--input=%s*' % temp_path, '--output=%s.result' % temp_path]) # Parse result file and compare. @@ -64,7 +63,7 @@ class GroupWithCoderTest(unittest.TestCase): sorted([('x:ann', 15), ('x:fred', 9), ('x:joe', 60), ('x:mary', 8)])) def test_basics_without_type_check(self): - # Run the workflow without --pipeline_type_check option. This will make sure + # Run the workflow without pipeline_type_check option. This will make sure # the typehints associated with all transforms will have default values and # therefore any custom coders will not be used. The default coder (pickler) # will be used instead. http://git-wip-us.apache.org/repos/asf/beam/blob/75ce5544/sdks/python/apache_beam/utils/pipeline_options.py ---------------------------------------------------------------------- diff --git a/sdks/python/apache_beam/utils/pipeline_options.py b/sdks/python/apache_beam/utils/pipeline_options.py index e86e379..9f57ee7 100644 --- a/sdks/python/apache_beam/utils/pipeline_options.py +++ b/sdks/python/apache_beam/utils/pipeline_options.py @@ -206,10 +206,6 @@ class TypeOptions(PipelineOptions): action='store_false', help='Disable type checking at pipeline construction ' 'time') - parser.add_argument('--pipeline_type_check', - action='store_true', - help='Enable type checking at pipeline construction ' - 'time') parser.add_argument('--runtime_type_check', default=False, action='store_true',