Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DFE03200C0D for ; Tue, 31 Jan 2017 17:51:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DE93E160B52; Tue, 31 Jan 2017 16:51:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 33F23160B36 for ; Tue, 31 Jan 2017 17:51:55 +0100 (CET) Received: (qmail 21187 invoked by uid 500); 31 Jan 2017 16:51:54 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 21178 invoked by uid 99); 31 Jan 2017 16:51:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2017 16:51:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 10775189AEB for ; Tue, 31 Jan 2017 16:51:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id uoqISn6AY3By for ; Tue, 31 Jan 2017 16:51:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A94FA5F238 for ; Tue, 31 Jan 2017 16:51:52 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D946CE034F for ; Tue, 31 Jan 2017 16:51:51 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 884182528C for ; Tue, 31 Jan 2017 16:51:51 +0000 (UTC) Date: Tue, 31 Jan 2017 16:51:51 +0000 (UTC) From: "Aljoscha Krettek (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] (BEAM-1346) Drop Late Data in ReduceFnRunner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 31 Jan 2017 16:51:56 -0000 [ https://issues.apache.org/jira/browse/BEAM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847109#comment-15847109 ] Aljoscha Krettek commented on BEAM-1346: ---------------------------------------- [~kenn], yes exactly, that's how I was able to home in on those two commits. The changes are still good, we just need another place in to code to do the late-data dropping. > Drop Late Data in ReduceFnRunner > -------------------------------- > > Key: BEAM-1346 > URL: https://issues.apache.org/jira/browse/BEAM-1346 > Project: Beam > Issue Type: Bug > Components: runner-core > Affects Versions: 0.5.0 > Reporter: Aljoscha Krettek > > I think these two commits recently broke late-data dropping for the Flink Runner (and maybe for other runners as well): > - https://github.com/apache/beam/commit/2b26ec8 > - https://github.com/apache/beam/commit/8989473 > It boils down to the {{LateDataDroppingDoFnRunner}} not being used anymore because {{DoFnRunners.lateDataDroppingRunner()}} is not called anymore when a {{DoFn}} is a {{ReduceFnExecutor}} (because that interface was removed). > Maybe we should think about dropping late data in another place, my suggestion is {{ReduceFnRunner}} but that's open for discussion. -- This message was sent by Atlassian JIRA (v6.3.15#6346)