Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Thu, 19 Jan 2017 18:00:32 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13035727.1484697988000.54573.1484848832753@Atlassian.JIRA>
In-Reply-To: <JIRA.13035727.1484697988000@Atlassian.JIRA>
References: <JIRA.13035727.1484697988000@Atlassian.JIRA> <JIRA.13035727.1484697988568@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1278) Use checkstyle on everything
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 19 Jan 2017 18:00:40 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830339#comment-15830339 ] 

ASF GitHub Bot commented on BEAM-1278:
--------------------------------------

GitHub user bimargulies-google opened a pull request:

    https://github.com/apache/beam/pull/1797

    [BEAM-1278] Apply checkstyle from the top.

    @dhalperi If this is OK, we should move the XML files to some plain old subdir of the top and eliminate the build-tools subdir.
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bimargulies-google/beam beam-1278-checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1797
    
----
commit 6d8a7e4361a677dc3d4a3be3ee98951c51ac67b4
Author: Benson Margulies <bimargulies@google.com>
Date:   2017-01-19T17:57:54Z

    [BEAM-1278] Apply checkstyle from the top.

----


> Use checkstyle on everything
> ----------------------------
>
>                 Key: BEAM-1278
>                 URL: https://issues.apache.org/jira/browse/BEAM-1278
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Benson Margulies
>            Assignee: Benson Margulies
>
> It is desirable to run checkstyle on everything, including poms.
> The problem is that the checkstyle rules come from the classpath, and that you can't have a dependency at the top level on a module of the project.
> There are some alternatives:
> * As of Maven 3.x, the entire checkstyle rule set can be inlined in the pom. A cure worse than the disease? You decide.
> * What other projects *(e.g. CXF) do is separately release an artifact with checkstyle and PMD rules. You can do that with a new github repo, or using the necessary Maven magic to have a subdirectory which is _not_ a module and contains a releasable pom. (It's all in how you configure the Maven release plugin).
> * You can just arrange for the rules to be at a URL. A URL, for example, to a specific version of a specific file on github?
> [~dhalperi@google.com]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)