Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E9AB6200BF6 for ; Tue, 10 Jan 2017 18:11:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E8180160B3D; Tue, 10 Jan 2017 17:11:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 39B20160B2C for ; Tue, 10 Jan 2017 18:11:02 +0100 (CET) Received: (qmail 62237 invoked by uid 500); 10 Jan 2017 17:11:01 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 62223 invoked by uid 99); 10 Jan 2017 17:11:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jan 2017 17:11:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EA6A6180028 for ; Tue, 10 Jan 2017 17:11:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WLsrHxy3ALxA for ; Tue, 10 Jan 2017 17:11:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 3B9C35FAF8 for ; Tue, 10 Jan 2017 17:10:59 +0000 (UTC) Received: (qmail 61402 invoked by uid 99); 10 Jan 2017 17:10:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jan 2017 17:10:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 683D72C1F56 for ; Tue, 10 Jan 2017 17:10:58 +0000 (UTC) Date: Tue, 10 Jan 2017 17:10:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1248) Combine with side inputs API should match ParDo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 Jan 2017 17:11:03 -0000 [ https://issues.apache.org/jira/browse/BEAM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815529#comment-15815529 ] ASF GitHub Bot commented on BEAM-1248: -------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/1755 > Combine with side inputs API should match ParDo > ----------------------------------------------- > > Key: BEAM-1248 > URL: https://issues.apache.org/jira/browse/BEAM-1248 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Kenneth Knowles > Priority: Minor > Labels: easy, starter > > From user@beam, the methods for adding side inputs to a Combine transform do not fully match those for adding side inputs to ParDo. > "ParDo has the .withSideInputs(Iterable>) version but also a varargs version withSideInputs(PCollectionView...) but Combine only has the Iterable version." -- This message was sent by Atlassian JIRA (v6.3.4#6332)