beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] beam pull request #1858: [BEAM-362] Move state-oriented remnants of OldDoFn ...
Date Fri, 27 Jan 2017 05:30:25 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-362] Move state-oriented remnants of OldDoFn to runners/core-java

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This moves `WindowingInternals`, `StateInternals`, and `TimerInternals` out of the Java
SDK and into runners/core-java. This is motivated by code health and user-facing API health
but also easy first steps towards easing alterations to `WatermarkHoldState`'s relationship
with `OutputTimeFn`, which is going away.
    Kudos to @jkff for moving `OldDoFn` which made all of this trivial.
    This will require a Dataflow worker image.

You can merge this pull request into a Git repository by running:

    $ git pull StateInternals

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1858
commit bb6b544bcbd2e9e6be8cb1f2c69ae1bc992ac3d5
Author: Kenneth Knowles <>
Date:   2017-01-27T05:00:15Z

    Eliminate use of InMemoryStateInternals in the Java SDK

commit 1fa7fc3d3969706a22d1a6969eefc45bb78a05b3
Author: Kenneth Knowles <>
Date:   2017-01-27T05:03:42Z

    Move InMemoryStateInternals to runners/core-java

commit 7fbd347e67da62e79ec4a96b81a8c88a63796100
Author: Kenneth Knowles <>
Date:   2017-01-27T05:05:09Z

    Delete long-deprecated StateContexts methods

commit 9f5aafb7be56f72ae8b9bcc69121830ea7e403ec
Author: Kenneth Knowles <>
Date:   2017-01-27T05:06:10Z

    Move WindowingInternals to runners/core-java

commit 93dc4d588aecfd791d7304c3286b5e89baef77f5
Author: Kenneth Knowles <>
Date:   2017-01-27T05:09:41Z

    Remove comment-only uses that block runners/core-java migrations

commit f33fb9a0bd98ccf4c3920becd5f50d68db525d36
Author: Kenneth Knowles <>
Date:   2017-01-27T05:13:14Z

    Move StateInternalsFactory to runners/core-java

commit be048787ab798b702b0d4d8535496b36e42fcd13
Author: Kenneth Knowles <>
Date:   2017-01-27T05:13:42Z

    Move TimerInternalsFactory to runners/core-java

commit cbe6ab56c937039675829b8cb1cf37d2c7ea4928
Author: Kenneth Knowles <>
Date:   2017-01-27T05:17:18Z

    Move TimerInternals to runners/core-java

commit ffc28ca73fcf4f4a268ba75bc848037b2a8b3a7a
Author: Kenneth Knowles <>
Date:   2017-01-27T05:19:04Z

    Move StateTable to runners/core-java

commit 9bac378b40f6c4e8d9b8856fef67a4e393f267d2
Author: Kenneth Knowles <>
Date:   2017-01-27T05:22:38Z

    Move StateInternals to runners/core-java

commit 1cfc00b9a81c46de8b650b993ed2abb9c6dddf50
Author: Kenneth Knowles <>
Date:   2017-01-27T05:26:04Z

    Move StateNamespace and related to runners/core-java


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message