beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] beam pull request #1842: [BEAM-886] Migrate CallableWrapperDoFn to extend Ne...
Date Wed, 25 Jan 2017 07:44:34 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/1842

    [BEAM-886] Migrate CallableWrapperDoFn to extend NewDoFn

    - Migrate the CallableWrapperDoFn class to extend NewDoFn instead of OldDoFn
    - Add a test for callables such as set/list as they can not be used with inspect module
    - Make sure all unittests pass
    - Performance tested the old vs new dofn and didn't find any changes in performance
    
    Future work:
    - Migrate the OldDoFn to New
    - Remove OldDoFn from the code
    - Rename NewDoFn to DoFn
    - Deprecate use of context
    
    R: @robertwb 
    CC: @aaltay
    --- 
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/incubator-beam BEAM-886-Add-NewDoFn-class-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1842
    
----
commit 38e4e8713263ba987ce374c94f59534904bcb9f3
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-01-25T07:19:40Z

    Migrate CallableWrapperDoFn to use the NewDoFn type

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message