beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] beam pull request #1831: Revert "Code cleanup now that all runners support w...
Date Tue, 24 Jan 2017 17:08:45 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/1831

    Revert "Code cleanup now that all runners support windowed side inputs."

    beam_PostCommit_Python_Verify failing.
    
    This reverts commit 6cb2f37efadfb52138b125fcaf51e703c2c5fd5a.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam postcommit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1831
    
----
commit 891d3a468f9af3e241f14d4dccadfbba3ae0689f
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-01-24T17:07:32Z

    Revert "Code cleanup now that all runners support windowed side inputs."
    
    beam_PostCommit_Python_Verify failing.
    
    This reverts commit 6cb2f37efadfb52138b125fcaf51e703c2c5fd5a.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message