beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #1822: [BEAM-882,BEAM-883,BEAM-878] Revert "Simplified API...
Date Tue, 24 Jan 2017 00:05:07 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/1822

    [BEAM-882,BEAM-883,BEAM-878] Revert "Simplified API surface verifications"

    This reverts commit 29ffaf3859ba9b4d8ba8529efc96fd5e105e21a3.
    
    The change to require all whitelisted packages to actually expose something failed in
the Dataflow runner postcommit. To be rolled forward after fixing.
    
    Be sure to do all of the following to help us incorporate your contribution quickly and
easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    @staslev I guess we need to fire off postcommits when we roll forward, though I would
never have guessed it.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam revert-ApiSurface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1822.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1822
    
----
commit 9248befbbba6b2d18cde3b7ee562b13af33681fc
Author: Kenneth Knowles <klk@google.com>
Date:   2017-01-24T00:02:24Z

    Revert "Simplified API surface verifications"
    
    This reverts commit 29ffaf3859ba9b4d8ba8529efc96fd5e105e21a3.
    
    The change to require all whitelisted packages to actually expose something
    failed in the Dataflow runner postcommit. To be rolled forward after
    fixing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message