beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] beam pull request #1805: [BEAM-886] Implement Annotation based NewDoFn in py...
Date Fri, 20 Jan 2017 22:21:25 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/1805

    [BEAM-886] Implement Annotation based NewDoFn in python SDK

    - Implement the new annotation based DoFn in python see https://s.apache.org/a-new-dofn
    - Handle typechecking in the NewDoFn
    - All unittests pass
    - None of the actual DoFn use the new ones yet
    
    Future work:
    - Performance test New Vs Old DoFn
    - Migrate the OldDoFn to New
    - Remove OldDoFn from the code
    - Rename NewDoFn to DoFn
    - Deprecate use of context 
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @robertwb  PTAL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/incubator-beam BEAM-886-Add-NewDoFn-class-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1805
    
----
commit f8ae4f2ccc399c6c0952f903b5e140986c61a933
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-01-20T22:17:00Z

    Implement Annotation based NewDoFn in python SDK

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message