beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #1793: [BEAM-1281] Encode GlobalWindow in one byte when it...
Date Thu, 19 Jan 2017 03:24:00 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/1793

    [BEAM-1281] Encode GlobalWindow in one byte when it is the whole stream

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    See JIRA and inline comment for explanation. TL;DR empty encodings are pretty fragile.
Many coders are sensitive to one byte addition, but this will not affect anything in the main
element collections, as they are within a `WindowedValueCoder`. The motivating case is actually
quite mundane.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam GlobalWindow-encoding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1793
    
----
commit 219d0cc8f5094240d2eafab6d2c1579aa2c70219
Author: Kenneth Knowles <klk@google.com>
Date:   2017-01-19T03:20:36Z

    Encoding GlobalWindow in one byte when it is the whole stream

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message