beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <>
Subject [GitHub] beam pull request #1773: Removes or moves away all OldDoFn code from SDK exc...
Date Thu, 12 Jan 2017 21:20:28 GMT
GitHub user jkff opened a pull request:

    Removes or moves away all OldDoFn code from SDK except OldDoFn itself

    This is possible now that the Dataflow worker no longer uses this code.
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull old-do-fn-cleanups

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1773
commit ad5eb06619b724236ad0d2a384b8ecf4c610f1e4
Author: Eugene Kirpichov <>
Date:   2016-12-10T01:21:40Z

    Removes code for wrapping DoFn as an OldDoFn

commit 50979f7262203987ef3ec4a3fbfeeb3f4ae769e7
Author: Eugene Kirpichov <>
Date:   2016-12-10T01:23:15Z

    Removes ArgumentProvider.windowingInternals

commit 149d52b56787bf3620db6b3adbad373366074a5d
Author: Eugene Kirpichov <>
Date:   2016-12-10T01:28:16Z

    Moves DoFnAdapters to runners-core

commit c2aa6ba5bf9ffb51c88ac17a1fa177d852822589
Author: Eugene Kirpichov <>
Date:   2017-01-12T21:10:40Z

    Removes some OldDoFn code from DoFnRunners
    DoFnRunners.createDefault() can be replaced with simpleRunner()
    at the existing call sites, since it is never called with a
    ReduceFnExecutor at those call sites.

commit 1790085d1cab97bf1ec7d96b729665368ed2bdcb
Author: Eugene Kirpichov <>
Date:   2017-01-12T21:17:11Z

    Moves PerKeyCombineFnRunners to Flink runner
    Flink is its only user. This removes the only remaining
    mentions of OldDoFn in the SDK that are not OldDoFn itself.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message