beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] beam pull request #1753: Captures assertion site and message in PAssert
Date Tue, 10 Jan 2017 00:58:12 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/1753

    Captures assertion site and message in PAssert

    This makes PAssert failures quite a bit easier to debug.
    Example message after this commit:
    
    ```
    java.lang.AssertionError: Some message
    
    	at org.apache.beam.sdk.testing.PAssert$PAssertionSite.capture(PAssert.java:384)
    	at org.apache.beam.sdk.testing.PAssert.that(PAssert.java:279)
    	at org.apache.beam.sdk.transforms.SplittableDoFnTest.testPairWithIndexWindowedTimestamped(SplittableDoFnTest.java:234)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            ...
    Caused by: java.lang.AssertionError:
    Expected: iterable over [<TimestampedValue(KV{z, 0}, 2017-01-10T00:38:28.000Z)>,
<TimestampedValue(KV{bb, 0}, 2017-01-10T00:38:29.000Z)>, <TimestampedValue(KV{bb,
1}, 2017-01-10T00:38:29.000Z)>, <TimestampedValue(KV{ccccc, 0}, 2017-01-10T00:38:30.000Z)>,
<TimestampedValue(KV{ccccc, 1}, 2017-01-10T00:38:30.000Z)>, <TimestampedValue(KV{ccccc,
2}, 2017-01-10T00:38:30.000Z)>, <TimestampedValue(KV{ccccc, 3}, 2017-01-10T00:38:30.000Z)>,
<TimestampedValue(KV{ccccc, 4}, 2017-01-10T00:38:30.000Z)>] in any order
         but: Not matched: <TimestampedValue(KV{a, 0}, 2017-01-10T00:38:28.000Z)>
    	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    	at org.junit.Assert.assertThat(Assert.java:956)
    	at org.junit.Assert.assertThat(Assert.java:923)
    	at org.apache.beam.sdk.testing.PAssert$AssertContainsInAnyOrder.apply(PAssert.java:1270)
    	at org.apache.beam.sdk.testing.PAssert$AssertContainsInAnyOrder.apply(PAssert.java:1)
            ...
    ```
    
    (as opposed to, basically, just the "Caused by" part)
    
    Inspiration for this CL was when this test failed while working on something else, but
didn't tell me which of the assertions was wrong. https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java#L157-L159
    
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam passert-location

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1753.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1753
    
----
commit a9182ae2725168fa59dd55d7b872d2ea45000461
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-01-10T00:38:50Z

    Captures assertion site and message in PAssert
    
    This makes PAssert failures quite a bit easier to debug.
    Example message after this commit:
    
    java.lang.AssertionError: Some message
    
    	at org.apache.beam.sdk.testing.PAssert$PAssertionSite.capture(PAssert.java:384)
    	at org.apache.beam.sdk.testing.PAssert.that(PAssert.java:279)
    	at org.apache.beam.sdk.transforms.SplittableDoFnTest.testPairWithIndexWindowedTimestamped(SplittableDoFnTest.java:234)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            ...
    Caused by: java.lang.AssertionError:
    Expected: iterable over [<TimestampedValue(KV{z, 0}, 2017-01-10T00:38:28.000Z)>,
<TimestampedValue(KV{bb, 0}, 2017-01-10T00:38:29.000Z)>, <TimestampedValue(KV{bb,
1}, 2017-01-10T00:38:29.000Z)>, <TimestampedValue(KV{ccccc, 0}, 2017-01-10T00:38:30.000Z)>,
<TimestampedValue(KV{ccccc, 1}, 2017-01-10T00:38:30.000Z)>, <TimestampedValue(KV{ccccc,
2}, 2017-01-10T00:38:30.000Z)>, <TimestampedValue(KV{ccccc, 3}, 2017-01-10T00:38:30.000Z)>,
<TimestampedValue(KV{ccccc, 4}, 2017-01-10T00:38:30.000Z)>] in any order
         but: Not matched: <TimestampedValue(KV{a, 0}, 2017-01-10T00:38:28.000Z)>
    	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    	at org.junit.Assert.assertThat(Assert.java:956)
    	at org.junit.Assert.assertThat(Assert.java:923)
    	at org.apache.beam.sdk.testing.PAssert$AssertContainsInAnyOrder.apply(PAssert.java:1270)
    	at org.apache.beam.sdk.testing.PAssert$AssertContainsInAnyOrder.apply(PAssert.java:1)
            ...
    
    (as opposed to, basically, just the "Caused by" part)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message