beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yk5 <...@git.apache.org>
Subject [GitHub] beam pull request #1736: [Beam-1245] Use @unittest.skip to skip avroio_test ...
Date Thu, 05 Jan 2017 03:06:27 GMT
GitHub user yk5 opened a pull request:

    https://github.com/apache/beam/pull/1736

    [Beam-1245] Use @unittest.skip to skip avroio_test cases

    when python-snappy is not installed.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yk5/beam tfrecord

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1736
    
----
commit 2dca45833f06329c30c303f257faaadf5c438211
Author: Younghee Kwon <younghee.kwon@gmail.com>
Date:   2017-01-05T02:39:29Z

    To use @unittest.skip to skip avroio_test cases when snappy is not imported.
    
    Without snappy installed, test log would look like:
    WARNING:root:snappy is not installed; some tests will be skipped.
    ...
    Ran 21 tests in 13.840s
    
    OK (skipped=3)
    ---
    
    With installed:
    ...
    Ran 21 tests in 14.464s
    
    OK

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message