beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From staslev <>
Subject [GitHub] beam pull request #1723: [BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoub...
Date Sun, 01 Jan 2017 15:14:15 GMT
GitHub user staslev opened a pull request:

    [BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoubles()/ofIntegers()…

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @lukecwik 
    About half way into this I was questioning the benefit-cost ratio, but since consistency
is what this PR is all about I figured bailing out would not be appropriate. 
    Let me know how it looks.

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-1223-Add-static-factory-methods-for-CombineFn-classes

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1723
commit 70f8db4021b7c9e49a280edb740667ae67224ef7
Author: Stas Levin <>
Date:   2017-01-01T11:58:32Z

    [BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoubles()/ofIntegers() and eliminated the
direction instantiation of the corresponding classes.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message