beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aljoscha Krettek (JIRA)" <j...@apache.org>
Subject [jira] (BEAM-1346) Drop Late Data in ReduceFnRunner
Date Tue, 31 Jan 2017 17:04:51 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847134#comment-15847134
] 

Aljoscha Krettek commented on BEAM-1346:
----------------------------------------

Also, isn't dropping late data before giving it to the {{ReduceFnRunner}} wrong when we have
a merging {{WindowFn}}? When an element arrives with a window that would be late with respect
to the watermark but that would end up getting merged into a bigger window that is not late
(which will therefore still be holding back the output watermark) we wouldn't have to drop
that element.

> Drop Late Data in ReduceFnRunner
> --------------------------------
>
>                 Key: BEAM-1346
>                 URL: https://issues.apache.org/jira/browse/BEAM-1346
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>    Affects Versions: 0.5.0
>            Reporter: Aljoscha Krettek
>
> I think these two commits recently broke late-data dropping for the Flink Runner (and
maybe for other runners as well):
> - https://github.com/apache/beam/commit/2b26ec8
> - https://github.com/apache/beam/commit/8989473
> It boils down to the {{LateDataDroppingDoFnRunner}} not being used anymore  because {{DoFnRunners.lateDataDroppingRunner()}}
is not called anymore when a {{DoFn}} is a {{ReduceFnExecutor}} (because that interface was
removed).
> Maybe we should think about dropping late data in another place, my suggestion is {{ReduceFnRunner}}
but that's open for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message