beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1326) WindowedWordCountIT generated output location can easily collide
Date Thu, 26 Jan 2017 21:55:24 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840528#comment-15840528
] 

ASF GitHub Bot commented on BEAM-1326:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/1856

    [BEAM-1326] Add prefix and suffix to WindowedWordCountIT output location

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam WindowedWordCountIT-collide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1856
    
----
commit 4d0225e8e29047dc7b4e0f5cea2414eaef4b038c
Author: Kenneth Knowles <klk@google.com>
Date:   2017-01-26T21:42:58Z

    Add prefix and suffix to WindowedWordCountIT output location

----


> WindowedWordCountIT generated output location can easily collide
> ----------------------------------------------------------------
>
>                 Key: BEAM-1326
>                 URL: https://issues.apache.org/jira/browse/BEAM-1326
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-java, testing
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> The generated output location is unique only up to the millisecond that the string is
generated. This can - and often does - collide between the streaming and batch variant of
the IT.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message