beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1325) DataflowRunner support for Class-Path jars
Date Thu, 26 Jan 2017 15:09:24 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839827#comment-15839827
] 

Daniel Halperin commented on BEAM-1325:
---------------------------------------

This SO post: http://stackoverflow.com/questions/25729319/how-does-a-classloader-load-classes-reference-in-the-manifest-classpath

seems to indicate there's no excellent way to do this. We could detect the case of a single
jar and go look for its specific classpath manifest, but that would be quite a hack.

> DataflowRunner support for Class-Path jars
> ------------------------------------------
>
>                 Key: BEAM-1325
>                 URL: https://issues.apache.org/jira/browse/BEAM-1325
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-dataflow
>            Reporter: Daniel Halperin
>            Assignee: Davor Bonaci
>
> See https://github.com/GoogleCloudPlatform/DataflowJavaSDK/issues/538
> The code that infers {{--filesToStage}} from the classpath does not seem to support a
classpath jar. which uses a {{Class-Path}} manifest to indicate which other jars are needed
at runtime. This is apparently a standard, approved way to pass the classpath.
> We need to add this support to {{DataflowRunner#detectClasspathResourcesToStage}}.
> (As {{FlinkRunner}} has copied this code, we should probably either pull the common utility
somewhere public or update the FlinkRunner too?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message