beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1315) FileBasedSink could write tmp files above the output prefix.
Date Fri, 27 Jan 2017 03:09:24 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840885#comment-15840885
] 

Daniel Halperin commented on BEAM-1315:
---------------------------------------

I don't think this needs to be a blocker for the release, so I'll downgrade it. The error
cases are reasonably limited and easily handleable.

> FileBasedSink could write tmp files above the output prefix.
> ------------------------------------------------------------
>
>                 Key: BEAM-1315
>                 URL: https://issues.apache.org/jira/browse/BEAM-1315
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Pei He
>
> FileBasedWriteOperation.TemporaryDirectoryBuilder tempDirBuilder =
>     new FileBasedWriteOperation.TemporaryDirectoryBuilder();
> tempDirBuilder.apply("/home/output/"),
> apply() returns "/home/temp-beam-output-2017-01-25_22-14-49"
> And, it was not under the output prefix "/home/output/".
> Examples of Path resolve:
> Paths.get("/home/output").resolve("temp-beam");
> Paths.get("/home/output/").resolve("temp-beam");
> /home/output/temp-beam
> /home/output/temp-beam
> Paths.get("/home/output").resolve("..").resolve("temp-beam");
> Paths.get("/home/output/").resolve("..").resolve("temp-beam");
> /home/output/../temp-beam
> /home/output/../temp-beam
> Paths.get("/home/output").resolveSibling("temp-beam");
> Paths.get("/home/output/").resolveSibling("temp-beam");
> /home/temp-beam
> /home/temp-beam



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message