beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1310) Add running integration tests for JdbcIO
Date Wed, 25 Jan 2017 02:03:26 GMT


ASF GitHub Bot commented on BEAM-1310:

GitHub user ssisk opened a pull request:

    BEAM-1310 Add integration tests for JdbcIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Hi @tgroh can you please take a look? (2nd time!)
    This adds an integration test & data loading script for Jdbc IO
    You'll note there are TODOs for verifying the contents of the rows in the tests - I will
get to those, but wanted to get a first, useful test in so that we can continue working on
the end to end integration test infrastructure.
    This IT demonstrates:
    * Having a separate load script for read tests
    * Using TestPipelineOptions that are not test based, but rather data source based.
    * Writing kubernetes scripts for instantiating an instance of the data source.

You can merge this pull request into a Git repository by running:

    $ git pull jdbc-it

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1841
commit e6007397e7d5508a4dfe39cf95ad4e1ceaaa2d6e
Author: Stephen Sisk <>
Date:   2017-01-25T01:56:35Z

    Add pg IT, load script and k8 script for JdbcIO


> Add running integration tests for JdbcIO
> ----------------------------------------
>                 Key: BEAM-1310
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
> Jdbc IO could use some integration tests! We'd like to have them run against a real list
instance of postgres.

This message was sent by Atlassian JIRA

View raw message