beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1291) KafkaIO: don't log warning in offset fetcher while closing the reader.
Date Fri, 20 Jan 2017 21:54:26 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832466#comment-15832466
] 

ASF GitHub Bot commented on BEAM-1291:
--------------------------------------

GitHub user rangadi opened a pull request:

    https://github.com/apache/beam/pull/1804

    [BEAM-1291] KafkaIO: don't log warnig in offset fetcher while closing.

    Don't log a warning in offset fetcher thread if the reader is already closed. This avoids
misleading warning in logs (especially with spark runner where the reader is closed after
each micro-batch).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rangadi/incubator-beam no_warn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1804
    
----
commit 44f17560122a09bad4e866495037daa309fb9ea8
Author: Raghu Angadi <rangadi@google.com>
Date:   2017-01-20T21:24:09Z

    KafkaIO: don't log warnig in offset fetcher while closing.

----


> KafkaIO: don't log warning in offset fetcher while closing the reader.
> ----------------------------------------------------------------------
>
>                 Key: BEAM-1291
>                 URL: https://issues.apache.org/jira/browse/BEAM-1291
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>
> When the KafkaIO reader is closed, it wakes up two background threads used for reading
from Kafka. The wakeup notification results in an exception. One of the threads logs a warning
with full stacktrace even though it is part of normal operation. It should not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message