beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1281) GlobalWindow needs non-empty encoding in StateNamespaces
Date Thu, 19 Jan 2017 21:34:26 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830646#comment-15830646
] 

ASF GitHub Bot commented on BEAM-1281:
--------------------------------------

Github user kennknowles closed the pull request at:

    https://github.com/apache/beam/pull/1793


> GlobalWindow needs non-empty encoding in StateNamespaces
> --------------------------------------------------------
>
>                 Key: BEAM-1281
>                 URL: https://issues.apache.org/jira/browse/BEAM-1281
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>
> Because the GlobalWindow is encoded to zero bytes, a StateNamespace built from the window
has a stringKey "//" while the global namespace's stringKey is "/". As paths, these are identical,
though we don't currently treat them as paths, quite. It isn't clear whether this is desirable.
Maybe it is harmless but it complicates parsing and interpretation.
> For a system that actually builds hierarchical paths out of, say, some prefix, the StateNamespace,
and a subsequent ID, the canonicalized path is the same so it is not possible to deserialize
to the original.
> There are other gotchas associated with zero-length encodings, such as APIs that return
zero bytes when there is no more data ready, versus returning zero bytes because the data
is representable in zero bytes, given the context of knowing what type of data is expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message