beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benson Margulies (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1278) Use checkstyle on everything
Date Thu, 19 Jan 2017 18:07:26 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830350#comment-15830350
] 

Benson Margulies commented on BEAM-1278:
----------------------------------------

Well, if you look at my PR, I seem to have found a magic alternative. Let me know what you
all think.


> Use checkstyle on everything
> ----------------------------
>
>                 Key: BEAM-1278
>                 URL: https://issues.apache.org/jira/browse/BEAM-1278
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Benson Margulies
>            Assignee: Benson Margulies
>
> It is desirable to run checkstyle on everything, including poms.
> The problem is that the checkstyle rules come from the classpath, and that you can't
have a dependency at the top level on a module of the project.
> There are some alternatives:
> * As of Maven 3.x, the entire checkstyle rule set can be inlined in the pom. A cure worse
than the disease? You decide.
> * What other projects *(e.g. CXF) do is separately release an artifact with checkstyle
and PMD rules. You can do that with a new github repo, or using the necessary Maven magic
to have a subdirectory which is _not_ a module and contains a releasable pom. (It's all in
how you configure the Maven release plugin).
> * You can just arrange for the rules to be at a URL. A URL, for example, to a specific
version of a specific file on github?
> [~dhalperi@google.com]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message