beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré (JIRA) <>
Subject [jira] [Commented] (BEAM-1278) Use checkstyle on everything
Date Thu, 19 Jan 2017 18:03:26 GMT


Jean-Baptiste Onofré commented on BEAM-1278:

In ServiceMix, Karaf, CXF, ... we have a "build" module released independently and used in
the other modules by the reactor. However, it requires for end-users to configure the IDE
to use it. And, checkstyle may be out of sync (depending of the exclusions, etc we want).

So, it depends the flexibility level we want. Having a specific "build" module atomic and
isolated can make sense if we accept a little less flexibility and sync.

> Use checkstyle on everything
> ----------------------------
>                 Key: BEAM-1278
>                 URL:
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Benson Margulies
>            Assignee: Benson Margulies
> It is desirable to run checkstyle on everything, including poms.
> The problem is that the checkstyle rules come from the classpath, and that you can't
have a dependency at the top level on a module of the project.
> There are some alternatives:
> * As of Maven 3.x, the entire checkstyle rule set can be inlined in the pom. A cure worse
than the disease? You decide.
> * What other projects *(e.g. CXF) do is separately release an artifact with checkstyle
and PMD rules. You can do that with a new github repo, or using the necessary Maven magic
to have a subdirectory which is _not_ a module and contains a releasable pom. (It's all in
how you configure the Maven release plugin).
> * You can just arrange for the rules to be at a URL. A URL, for example, to a specific
version of a specific file on github?
> []

This message was sent by Atlassian JIRA

View raw message