beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1188) More Verifiers For Python E2E Tests
Date Tue, 17 Jan 2017 22:59:26 GMT


ASF GitHub Bot commented on BEAM-1188:

GitHub user markflyhigh reopened a pull request:

    [BEAM-1188] Fix Incorrect Value Parsing in Test Pipeline Test

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Use `split('=')[1]` to parse value from a key-value string (using `=` as separator) have
a potential problem. 
    In `test_append_verifier_in_extra_opt`, the value is a pickled string and contains more
than one `=`, we should stop parsing at the first `=` to get correct value. 

You can merge this pull request into a Git repository by running:

    $ git pull fix-test-pipeline-test

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1784
commit 8cb8a10d14d4994de55683adc3361012dd793c15
Author: Mark Liu <>
Date:   2017-01-17T19:54:02Z

    Fix Incorrect Split in Test Pipeline Test


> More Verifiers For Python E2E Tests
> -----------------------------------
>                 Key: BEAM-1188
>                 URL:
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py, testing
>            Reporter: Mark Liu
>            Assignee: Mark Liu
> Add more basic verifiers in e2e test to verify output data in different storage/fs:
> 1. File verifier: compute and verify checksum of file(s) that’s stored on a filesystem
(GCS / local fs). 
> 2. Bigquery verifier: query from Bigquery table and verify response content. 
> ...
> Also update TestOptions.on_success_matcher to accept a list of matchers instead of single
> Note: Have retry when doing IO to avoid test flacky that may come from inconsistency
of the filesystem. This problem happened in Java integration tests.

This message was sent by Atlassian JIRA

View raw message