beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré (JIRA) <j...@apache.org>
Subject [jira] [Commented] (BEAM-1184) Add integration tests for ElasticsearchIO
Date Tue, 17 Jan 2017 23:29:26 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827039#comment-15827039
] 

Jean-Baptiste Onofré commented on BEAM-1184:
--------------------------------------------

As discussed together, [~sisk] will send an e-mail on the mailing list to provide details.
Here's roughly the main points:

* For the UTest, as a best effort, an IO should:
1. Provide an interface {{IOService}} describing the behavior of the IO backend.
2. Provide a {{FakeIOService}} mocking the IO backend and used in the utest.
3. Provide a {{IOServiceImpl}} which is actually used in the IO to interact with the backend.

* For the ITest, as a best effort, an  IO should:
1. Provide the code to load sample data into the test backend (script, java code, ...).
2. Provide the scripts (kubernetes as first choice, however Mesos/Marathon or Dockerfile is
acceptable) to bootstrap the backend.
3. Provide the actual  integration tests code containing {{PipelineOptions}} used to pass
the location/endpoint of the backend resource.

> Add integration tests for ElasticsearchIO
> -----------------------------------------
>
>                 Key: BEAM-1184
>                 URL: https://issues.apache.org/jira/browse/BEAM-1184
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-extensions
>            Reporter: Stephen Sisk
>            Assignee: Jean-Baptiste Onofré
>
> In https://github.com/apache/incubator-beam/pull/1439#pullrequestreview, the original
PR included a dockerfile and an integration test that ran against an ES instance in that dockerfile.

> We are working on infrastructure to stand up docker containers for this kind of testing,
but aren't quite ready for it, so we pulled the scripts, dockerfile+IT out of that PR. This
issue tracks checking that work in once we can take advantage of it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message