beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1100) Consider removing pylint from mvn verify
Date Fri, 27 Jan 2017 22:39:24 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843598#comment-15843598
] 

ASF GitHub Bot commented on BEAM-1100:
--------------------------------------

Github user aaltay closed the pull request at:

    https://github.com/apache/beam/pull/1807


> Consider removing pylint from mvn verify
> ----------------------------------------
>
>                 Key: BEAM-1100
>                 URL: https://issues.apache.org/jira/browse/BEAM-1100
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Ahmet Altay
>            Priority: Critical
>
> pylint depends on git commands for getting a list of changed files to run the linter
on. This does not make sense in some cases (for example when in the case code was copied/packaged
out of git structure). A few possible remedies could be considered:
> - Remove pylint step from mvn verify
> - Add an option to pylint run on whole code base and use this in mvn verify
> - Change pylint to run on the whole code base (instead of just changed files)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message