beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-882) Make ApiSurfaceTest detect the java package/module under test
Date Mon, 16 Jan 2017 14:27:26 GMT

    [ https://issues.apache.org/jira/browse/BEAM-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824029#comment-15824029
] 

ASF GitHub Bot commented on BEAM-882:
-------------------------------------

GitHub user staslev opened a pull request:

    https://github.com/apache/beam/pull/1780

    [BEAM-882,BEAM-883,BEAM-878] Simplified the creation of new API surface tests.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    R: @dhalperi @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/staslev/beam BEAM-882-878-883-fixing-ApiSurfaceTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1780
    
----
commit 31a7864ba5d7636f3d120540d201441498e6c4b8
Author: Stas Levin <staslevin@gmail.com>
Date:   2017-01-16T14:20:25Z

    [BEAM-882,BEAM-883,BEAM-878] Simplified creating new API surface verifications.

----


> Make ApiSurfaceTest detect the java package/module under test
> -------------------------------------------------------------
>
>                 Key: BEAM-882
>                 URL: https://issues.apache.org/jira/browse/BEAM-882
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: Not applicable
>            Reporter: Kenneth Knowles
>            Priority: Trivial
>              Labels: easy, easyfix, newbie, starter
>             Fix For: Not applicable
>
>
> {{ApiSurfaceTest}} in the {{sdks/java/core}} is the class responsible for protecting
our public API surface.
> This test walks the public signatures of all modules and explicitly verifies that everything
is on a whitelist. This is how we control what dependencies we expose to our users, so that
Beam can keep a tight, stable API surface.
> Today you must indicate what Java package to scan, such as `org.apache.beam.sdk`. It
would be nice for this to be automatically determined.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message