beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stas Levin (JIRA)" <>
Subject [jira] [Commented] (BEAM-849) Redesign PipelineResult API
Date Mon, 09 Jan 2017 19:11:58 GMT


Stas Levin commented on BEAM-849:

I see your point. 

At the moment the documentation for {{getState()}} says 'Retrieves the current state of the
pipeline execution' so it seems ok to return a non-terminal state on account of the "current"
part and the asynchronous nature of the pipeline. If, however, the intention is to return
only terminal states we might want to change this bit in the javadoc. 

IMHO, it makes sense to return a non terminal state as long as it's well communicated to the
user, perhaps even by making it explicit by changing the method's name to reflect it, e.g.

> Redesign PipelineResult API
> ---------------------------
>                 Key: BEAM-849
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Pei He
> Current state: 
> Jira addresses waitUntilFinish() and cancel().

> However, there are additional work around PipelineResult: 
> need clearly defined contract and verification across all runners 
> need to revisit how to handle metrics/aggregators 
> need to be able to get logs

This message was sent by Atlassian JIRA

View raw message