beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-177) Integrate code coverage to build and review process
Date Tue, 17 Jan 2017 22:46:26 GMT

    [ https://issues.apache.org/jira/browse/BEAM-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826980#comment-15826980
] 

ASF GitHub Bot commented on BEAM-177:
-------------------------------------

GitHub user jasonkuster opened a pull request:

    https://github.com/apache/beam/pull/1786

    [BEAM-177] Add coveralls back to repo now that credentials masking works.

    Signed-off-by: Jason Kuster <jasonkuster@google.com>
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @davorbonaci @dhalperi 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasonkuster/incubator-beam coveralls

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1786
    
----
commit 25b01e66d1e60d8c83f31e6219579225917741df
Author: Jason Kuster <jasonkuster@google.com>
Date:   2017-01-17T22:37:51Z

    Add coveralls back to repo now that credentials masking works.
    
    Signed-off-by: Jason Kuster <jasonkuster@google.com>

----


> Integrate code coverage to build and review process
> ---------------------------------------------------
>
>                 Key: BEAM-177
>                 URL: https://issues.apache.org/jira/browse/BEAM-177
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Jason Kuster
>
> We cannot use codecov, but we can use coveralls. We have the maven plugin included in
the pom and need to invoke it appropriately in our various builds, and disseminate knowledge
about browser extensions to get it into the pull request UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message